Say what else returns -1 from the coroutine flock, and where it does not run - #19
Merged
Merged
Conversation
…not run The docblock listed three of the four ways the call comes back without the lock; the timer that fails to arm was missing. The branch comment claimed everything that can wait goes to the coroutine, while two clauses of the condition it sits above send a waiting lock to the blocking syscall instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments only, follow-up to #18, found by a second review.
The docblock of
php_stdiop_flock_async()listed three of the four ways it returns without the lock — a retry timer that cannot be created or registered was missing, and it leaves an exception set, which a caller has to know about.The comment above the
PHP_STREAM_OPTION_LOCKINGbranch said that anything which can wait goes to the coroutine. Two clauses of the condition it annotates say otherwise: with async off, and inside the scheduler, a waiting lock still blocks the whole thread.